Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

refactor!: drop custom directives #274

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Sep 17, 2024

Temporarily drop the implementation of custom directives; we may redo this part in the future.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 3d6618f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/66eb0a1db5b12b0008023342
😎 Deploy Preview https://deploy-preview-274--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 3d6618f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/66eb0a1de203bb000807af80
😎 Deploy Preview https://deploy-preview-274--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 17, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.9 kB 28.5 kB 25.1 kB
compiler-vapor.global.prod.js 58.9 kB 19.6 kB 17.7 kB
runtime-dom.global.prod.js 101 kB 37.9 kB 34 kB
runtime-vapor.global.prod.js 45.2 kB (-4.1 kB) 16.8 kB (-1.56 kB) 15.4 kB (-1.41 kB)
vue-vapor.global.prod.js 101 kB (-4.1 kB) 34.9 kB (-1.56 kB) 31.4 kB (-1.3 kB)
vue.global.prod.js 159 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.2 kB 18.9 kB 17.3 kB
createApp 55.8 kB 21.4 kB 19.6 kB
createSSRApp 59.8 kB 23.1 kB 21 kB
defineCustomElement 60.6 kB 22.9 kB 20.9 kB
vapor 45.8 kB (-4.11 kB) 17.1 kB (-1.55 kB) 15.6 kB (-1.4 kB)
overall 69.5 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Sep 17, 2024

Open in Stackblitzplayground

@vue/compiler-dom

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-dom@274

@vue/compiler-core

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-core@274

@vue/compiler-sfc

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-sfc@274

@vue/compiler-ssr

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-ssr@274

@vue/compiler-vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-vapor@274

@vue/reactivity

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/reactivity@274

@vue/runtime-core

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-core@274

@vue/runtime-dom

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-dom@274

@vue/runtime-shared

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-shared@274

@vue/runtime-vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-vapor@274

@vue/shared

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/shared@274

@vue/server-renderer

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/server-renderer@274

vue

pnpm add https://pkg.pr.new/vuejs/core-vapor/vue@274

@vue/compat

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compat@274

@vue/vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/vapor@274

commit: 3d6618f

@sxzz sxzz force-pushed the refactor/drop-custom-directive branch 4 times, most recently from c6c353e to b5040d9 Compare September 18, 2024 17:09
@sxzz sxzz force-pushed the refactor/drop-custom-directive branch from b5040d9 to 3d6618f Compare September 18, 2024 17:12
@sxzz sxzz marked this pull request as ready for review September 18, 2024 17:14
@sxzz sxzz merged commit e1bedb8 into main Sep 18, 2024
10 checks passed
@sxzz sxzz deleted the refactor/drop-custom-directive branch September 18, 2024 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant