This repository was archived by the owner on Jul 19, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 114
refactor(compile-vapor): wrap the event handler with withModifiers
or withKeys
#300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
Open in Stackblitz • playground @vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-shared
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
@vue/vapor
commit: |
edison1105
commented
Dec 1, 2024
@@ -57,7 +57,7 @@ const importMap = computed(() => { | |||
'vue/vapor': vapor, | |||
}, | |||
} | |||
if (useVaporMode.value) vaporImportMap.imports!.vue = vapor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line will cause vue
and vue/vapor
to use the same URL, witch will lead some bugs, see Playground
{
"imports": {
"vue": "https://vapor-repl.netlify.app/vue-vapor.esm-browser.js",
"vue/server-renderer": "https://vapor-repl.netlify.app/server-renderer.esm-browser.js",
"vue/vapor": "https://vapor-repl.netlify.app/vue-vapor.esm-browser.js"
},
"scopes": {}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the row is deleted, the getCurrentInstance()
return value will be undefined in setup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.