Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.4 Breaks IE conditional statements #4125

Closed
darrylhein opened this issue Nov 4, 2016 · 2 comments
Closed

v2.0.4 Breaks IE conditional statements #4125

darrylhein opened this issue Nov 4, 2016 · 2 comments

Comments

@darrylhein
Copy link

Vue.js version

2.0.4 (works in 2.0.3)

Reproduction Link

http://codepen.io/darrylhein/pen/BQabVR

Steps to reproduce

Add IE conditional comments with HTML inside them.

What is Expected?

Stay hidden unless the version of IE is matched. Thus hidden in all other non-IE browsers.

What is actually happening?

IE conditional comments are removed and thus content inside the conditional is always displayed.
If there is no HTML then the content is hidden (as it should be).

@darrylhein darrylhein changed the title Breaks IE conditional statements (removes) Breaks IE conditional statements Nov 4, 2016
@darrylhein darrylhein changed the title Breaks IE conditional statements v2.0.4 Breaks IE conditional statements Nov 4, 2016
@yyx990803
Copy link
Member

FYI Vue removes the comments during template parsing, so supposedly the conditional content would not show in IE8 either. You probably don't want to use Vue to compile these conditional comments at all.

darrylhein added a commit to xmmedia/starter_symfony that referenced this issue Nov 5, 2016
@darrylhein
Copy link
Author

Well that's good to know. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants