Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component root node changing is broken #4284

Closed
localvoid opened this issue Nov 23, 2016 · 4 comments · Fixed by #4299
Closed

Component root node changing is broken #4284

localvoid opened this issue Nov 23, 2016 · 4 comments · Fixed by #4299
Assignees
@HerringtonDarkholme
Labels
bug

Comments

@localvoid
Copy link

Reproduction Link

http://codepen.io/localvoid/pen/WojeKN
@HerringtonDarkholme
Copy link
Member

Thanks, this is vue's repository. If you have question on react, please go to https://github.com/facebook/react/

@localvoid
Copy link
Author

@HerringtonDarkholme this is vue2 issue, if you don't care about correct behavior in vue, you may ignore this issue.

@localvoid
Copy link
Author

cc @yyx990803 check this, almost all virtual dom implementations have this issue.

@HerringtonDarkholme
Copy link
Member

HerringtonDarkholme commented Nov 23, 2016 •
edited by yyx990803
Loading

Sorry, I misread the link. Reopened. It would've clearer to just paste a direct link to vue's reproduction rather than adding a React entry point.

https://jsfiddle.net/localvoid/d3bohccg/

@HerringtonDarkholme HerringtonDarkholme self-assigned this Nov 23, 2016
@yyx990803 yyx990803 added the bug label Nov 23, 2016
HerringtonDarkholme added a commit to HerringtonDarkholme/vue that referenced this issue Nov 23, 2016
@HerringtonDarkholme
fix vuejs#4284, recursively update vnode element
9df2cf5
HerringtonDarkholme added a commit to HerringtonDarkholme/vue that referenced this issue Nov 23, 2016
@HerringtonDarkholme
fix vuejs#4284, ensure vm's vnode is up to date
fe1df29
@HerringtonDarkholme HerringtonDarkholme mentioned this issue Nov 23, 2016
Merged
yyx990803 pushed a commit that referenced this issue Nov 23, 2016
@HerringtonDarkholme @yyx990803
Ensure Vue instance's vnode and element is up to date (#4299)
fce3f04 
* fix #4284, recursively update vnode element

* fix #4284, ensure vm's vnode is up to date

* add test for edge case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HerringtonDarkholme HerringtonDarkholme

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure Vue instance's vnode and element is up to date HerringtonDarkholme/vue
3 participants
@localvoid @yyx990803 @HerringtonDarkholme