Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-show is firing late on 2.5.1 #6813

Closed
ericcirone opened this issue Oct 13, 2017 · 6 comments

Comments

@ericcirone
Copy link

@ericcirone ericcirone commented Oct 13, 2017

Version

2.5.1

Reproduction link

https://codepen.io/ericcirone/pen/pWOrMB

Steps to reproduce

Go here - https://codepen.io/ericcirone/pen/pWOrMB
This is on 2.5.1 At < 1000px wide the test list should get hidden. If you go back and forth over that threshold you can make the list flash. It flashes because it is hidden by v-show. But in the CSS i make the list vertical under 1000px. It seems that v-show is firing a too late.

You can see the comparison to 2.4.4 here https://codepen.io/ericcirone/pen/Oxoxzr
On 2.4.4 you can not get the list to flash at the larger size.

What is expected?

List should be hidden at < 1000px.

What is actually happening?

List flashes vertical for a split second before disappearing.


Just noticed this when updating to 2.5.1. Hopefully its a quick fix. I'm using this behavior on a menu bar and now when you make the screen smaller its very janky.

@ericcirone

This comment has been minimized.

Copy link
Author

@ericcirone ericcirone commented Oct 13, 2017

Here is a video of the issue, just to further show it.

https://youtu.be/9BRqQa2Q9a4

@yyx990803 yyx990803 closed this in 4e0c485 Oct 13, 2017
@doits

This comment has been minimized.

Copy link

@doits doits commented Oct 14, 2017

You can see the comparison to 2.4.4 here https://codepen.io/ericcirone/pen/Oxoxzr
On 2.4.4 you can not get the list to flash at the larger size.

It flashes here for me, too, even with 2.4.4. (Firefox 57.0b8)

@fritx

This comment has been minimized.

Copy link

@fritx fritx commented Oct 15, 2017

@doits

This comment has been minimized.

Copy link

@doits doits commented Oct 15, 2017

@fritx 2.5.2 still flashes for me on resizing: https://codepen.io/anon/pen/PJyOJM

@cannap

This comment has been minimized.

Copy link

@cannap cannap commented Oct 16, 2017

i can also see on IE Edge

@ericcirone

This comment has been minimized.

Copy link
Author

@ericcirone ericcirone commented Oct 16, 2017

The issue definitely seems to be fixed in Chrome, but I do still see the issue in Safari and Firefox. Also I can see the issue in Safari and Firefox on 2.4.4 as well.

@yyx990803 So for situations like this, where I have CSS changing the appearance and Vue changing the appearance and wanting both to work exactly at the same moment, is it safe to say it should just all be done in CSS or all be done in Vue to make sure things are changed exactly at the same time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.