Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weex): stop trim css units in richtext component #6927

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

Hanks10100
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

Other information:

The native render engine of Weex supports the px unit, and recommend writing CSS units.

  • Remove the trimCSSUnit method.
  • Modify the test cases to support CSS units.
  • Add flow type annotations.

+ Remove the `trimCSSUnit` method.
+ Modify the test cases to support css units.
+ Add flow type annotations.
@yyx990803 yyx990803 merged commit 8a784d8 into vuejs:dev Oct 31, 2017
erweixin pushed a commit to erweixin/vue that referenced this pull request Dec 15, 2017
+ Remove the `trimCSSUnit` method.
+ Modify the test cases to support css units.
+ Add flow type annotations.
lovelope pushed a commit to lovelope/vue that referenced this pull request Feb 1, 2018
+ Remove the `trimCSSUnit` method.
+ Modify the test cases to support css units.
+ Add flow type annotations.
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
+ Remove the `trimCSSUnit` method.
+ Modify the test cases to support css units.
+ Add flow type annotations.
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
+ Remove the `trimCSSUnit` method.
+ Modify the test cases to support css units.
+ Add flow type annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants