Skip to content

Better comments in shared/util.js code #8528

@sagirk

Description

@sagirk

Version

2.5.17-beta.0

Reproduction link

https://github.com/vuejs/vue/blob/dev/src/shared/util.js

Steps to reproduce

  1. Go to https://github.com/vuejs/vue/blob/dev/src/shared/util.js

What is expected?

Comments in the shared/util.js code to have

  • Consistent use of periods
  • Consistent use of commas
  • Consistent capitalization
  • Correct use of articles (a, an, the)
  • Correct pluralization
  • Shorter sentences in polyfillBind description
  • Clearer description for genStaticKeys
  • Description for looseIndexOf to be present

What is actually happening?

None of the above


I am working on a PR to improve the above. Interestingly, this will be my first contribution to Vue.js.

EDIT: Raised the PR — #8529

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions