Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): DevTools recommendation shows for all browsers #8638

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

AlexMaguey
Copy link

Closes #8634

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva
Copy link
Member

posva commented Aug 11, 2018

Thanks for the PR but let's wait for the confirmation first 🙂

@manniL
Copy link
Contributor

manniL commented Oct 16, 2018

ping

@yyx990803 yyx990803 added this to Todo in 2.6 Dec 5, 2018
@Justineo
Copy link
Member

Justineo commented Dec 6, 2018

It seems to be the only place where isChrome is used. We can delete its definition as well.

@yyx990803 yyx990803 moved this from Todo to In progress in 2.6 Dec 20, 2018
@yyx990803 yyx990803 changed the base branch from dev to 2.6 December 20, 2018 22:04
@yyx990803 yyx990803 merged commit 22ad266 into vuejs:2.6 Dec 20, 2018
2.6 automation moved this from In progress to Done Dec 20, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.6
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants