New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR publich path https://xx generated to https:/xx #9145

Closed
fe-shinemo opened this Issue Dec 5, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@fe-shinemo

fe-shinemo commented Dec 5, 2018

Version

2.5.18-beta.0

Reproduction link

https://github.com/vuejs/vue/blob/v2.5.18-beta.0/src/server/template-renderer/index.js

Steps to reproduce

No need to repro, it's written in the code.

return path.posix.join(this.publicPath, file)

here it's used path.posix.join ( #8177 ), thus if publicPath begin with https:// or http://, one of the double slashes disapper, become https:/.

What is expected?

publicPath = ''https://cdn.nuxtjs.org/" generates "https://cdn.nuxtjs.org/xxx.js"

What is actually happening?

publicPath = ''https://cdn.nuxtjs.org/" generates "https:/cdn.nuxtjs.org/xxx.js"

@yyx990803 yyx990803 added the regression label Dec 5, 2018

@yyx990803 yyx990803 closed this in 078f9c7 Dec 5, 2018

yyx990803 added a commit that referenced this issue Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment