feat: add a prop named error to the ErrorComponent when load async …
#10037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…component rejected(vuejs#10027)
posva
reviewed
May 16, 2019
| }) | ||
|
|
||
| it('with error component', done => { | ||
| it('with error component + a prop named error', done => { |
There was a problem hiding this comment.
It's better to keep the old test and add a new one that shows the error
| component: new Promise((resolve, reject) => { | ||
| setTimeout(() => { | ||
| reject() | ||
| reject('error') |
There was a problem hiding this comment.
Errors are usually new Error('message'), so better test it that way so it is closer to real scenarios
…t when load async component rejected (vuejs#10027)
… when load async component timeout (vuejs#10027)
|
Thank for your review. I did something for your suggestion. |
lucalves
reviewed
Jun 13, 2019
| : factory.resolved | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I suggested you include a comment, preceded by the pull request number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…component rejected(#10027)
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
issues number: 10027