Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set only flex-wrap #10380

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@DanielRuf
Copy link
Contributor

commented Aug 12, 2019

This PR replaces the shorthand flex-flow with the right long version flex-wrap.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@DanielRuf DanielRuf changed the title Set only flex-wrap fix: set only flex-wrap Aug 12, 2019

@DanielRuf DanielRuf force-pushed the DanielRuf:fix/set-only-flex-wrap branch from eae8526 to 2e539f3 Aug 12, 2019

@posva

posva approved these changes Aug 12, 2019

Copy link
Member

left a comment

Thanks!

@posva posva merged commit 369dbe7 into vuejs:dev Aug 12, 2019

5 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
@vue-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Hey @DanielRuf, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@DanielRuf DanielRuf deleted the DanielRuf:fix/set-only-flex-wrap branch Aug 12, 2019

sdrees added a commit to sdrees/vue that referenced this pull request Aug 13, 2019

Merge pull request #4 from vuejs/dev
chore(benchmarks): use flex-wrap (vuejs#10380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.