Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix prop constructor type inference #10779

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@ktsn
Copy link
Member

ktsn commented Oct 30, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I found that for some reason any type in new (...args: any[]): T & object prevent to pick up prop type in the newer TypeScript version. Replacing it with never fixes the problem.

The meaning of the code is not changed as a function argument type is contravariant and never type is of bottom type, that is, the entire new (...args: never[]): T & object type accepts any constructor type having any argument types which the original code intends.

ktsn referenced this pull request Oct 30, 2019
@ktsn ktsn added the typescript label Oct 30, 2019
@yyx990803 yyx990803 merged commit 4821149 into vuejs:dev Oct 30, 2019
5 checks passed
5 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
sthagen added a commit to sthagen/vue that referenced this pull request Oct 31, 2019
fix(types): fix prop constructor type inference (vuejs#10779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.