Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix mergeHook when parentVal is not an array #10877
Open
+4
−2
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jeanphilippeds commentedNov 30, 2019
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This is related to a vue-router issue.
A bit of context:
VueRouter comes with 3 hooks (beforeRouteEnter, beforeRouteLeave, beforeRouteUpdate).
The merging strategy to deal with inheritance with these hooks is defined in src/install.js in VueRouter.
The chosen strategy is mergeHook (in vue/src/core/util/options.js, the same as the created hook of Vue).
As you can see in the code, mergeHook is expecting a different type parentVal or childVal. If parentVal ends up not being an array, the code crashes.
The fix we propose is to put parentVal into an array before calling concat, if parentVal is not an array.