Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix(ssr) textarea domProps keeps falsy values (#10803) #11102

Closed
wants to merge 1 commit into from

Conversation

lKk2
Copy link

@lKk2 lKk2 commented Feb 12, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lKk2 lKk2 requested a review from posva February 13, 2020 14:41
@contribu
Copy link

contribu commented Feb 15, 2020

This is inconsistent with client-side rendering.
Reproduction: https://codesandbox.io/s/black-cloud-4j48b

I think it is better to use toString in shared/util.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants