Skip to content

Conversation

sun-Ame
Copy link

@sun-Ame sun-Ame commented Jun 17, 2022

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@sun-Ame
Copy link
Author

sun-Ame commented Jun 17, 2022

if-return-return

@Justineo
Copy link
Member

原来的代码更明确是两条并列的逻辑分支,并不是 early return 的逻辑,我觉得也比较清晰。这类没有明显客观收益的改动,我们暂时不会接受,谢谢。

@Justineo Justineo closed this Jun 17, 2022
@sun-Ame
Copy link
Author

sun-Ame commented Jun 17, 2022 via email

@haoqunjiang haoqunjiang mentioned this pull request Nov 19, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants