Occurred TypeError in Observer.create #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +47,7 @@ Observer.create = function (value, vm) { | |||
| } | |||
| var ob | |||
| if ( | |||
| value.hasOwnProperty('__ob__') && | |||
| '__ob__' in value && | |||
There was a problem hiding this comment.
Thanks, but using in operator this would return true if the __ob__ is defined on the prototype as well. We can use Object.prototype.hasOwnProperty.call(value, '__ob__').
|
I fixed. 😸 |
yyx990803
added a commit
that referenced
this pull request
Nov 9, 2015
Occurred TypeError in Observer.create
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create the object with
Object.create(null)for plugin, and when it would try to define as reactivity object withVue.util.defineReactive, occured theTypeErrorinObserver.create.Please see the following jsfiddle:
https://jsfiddle.net/kazupon/yo2cmsLp/1/
In Vue.js, Can I define the reactity object was created with
Object.create(null)?If this is bug, I hope that you will check PR.