[fix] Don't remove newlines during parseText #2620
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `text` is being used as the key in `cache.get(text)` and the cache is checked *before* newlines were removed, the cache would always miss if the input `text` had *any* newlines. I updated `tagRe` to match tags which contain newlines, and added an extra test case to ensure newlines outside of tags are preserved
|
Updated with passing tests |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
textis being used as the key incache.get(text)and thecache is checked before newlines were removed, the cache would always
miss if the input
texthad any newlines.I updated
tagReto match tags which contain newlines, and added anextra test case to ensure newlines outside of tags are preserved