Fix bug: directive sort is not stable on Chrome #3149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building a tabs component. It is used like this:
Live demo(Works fine)
It works fine when there are less than 10
<tab>s
. But tabs will disorder when I have more than 10<tab>s
.Live demo(Bug)
The main reason is that the directive sorting by priority is not stable on Chrome.
I fixed this bug using a sort method(time: O(n), space: O(n)), It also can be fixed using a stable sort method such as merge sort.