Skip to content

Add missing string handler in v-for #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2016
Merged

Add missing string handler in v-for #4499

merged 1 commit into from
Dec 16, 2016

Conversation

posva
Copy link
Member

@posva posva commented Dec 16, 2016

Fix #4497

At first I added an else if at the end since strings are rarely used in v-for loops but it felt wrong not to reuse the first if

kazupon
kazupon approved these changes Dec 16, 2016
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yyx990803 yyx990803 merged commit 974247f into vuejs:dev Dec 16, 2016
@posva posva deleted the add-string-v-for branch December 17, 2016 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kazupon kazupon kazupon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@posva @kazupon @yyx990803