New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments option to allow user kept comments in template #5951

Merged
merged 4 commits into from Jun 30, 2017

Conversation

Projects
None yet
2 participants
@Kingwl
Member

Kingwl commented Jun 22, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
#5392
I can not confirm that this is not a BC

@Kingwl

This comment has been minimized.

Show comment
Hide comment
@Kingwl

Kingwl Jun 22, 2017

Member

it seems so complex
maybe i can implement that with AstText

Member

Kingwl commented Jun 22, 2017

it seems so complex
maybe i can implement that with AstText

@yyx990803 yyx990803 merged commit e4da249 into vuejs:dev Jun 30, 2017

1 check was pending

ci/circleci CircleCI is running your tests
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment