fix #6193, change event should not be triggered if each value still matches an option #6194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkzing
force-pushed
the
fix-6193
branch
3 times, most recently
from
e90d6d1
to
d9b2f41
Compare
change event should not be triggered if still can found matching option for each value
nickmessing
approved these changes
Jul 23, 2017
Kingwl
reviewed
Jul 24, 2017
| @@ -101,6 +108,15 @@ function setSelected (el, binding, vm) { | |||
| } | |||
| } | |||
|
|
|||
| function hasNoMatchingOption (value, options) { | |||
There was a problem hiding this comment.
how about Array.prototype.some or every😅
There was a problem hiding this comment.
Yes, it would be better to use [].some.
Actually I just did revert changes made in c90b140, and didn't think about that. 😅
Will do it later.
Kingwl
approved these changes
Jul 25, 2017
|
Is it released ? |
|
It hasn't been merged yet, so: no. |
yyx990803
pushed a commit
that referenced
this pull request
Aug 29, 2017
FranklinTesla
pushed a commit
to FranklinTesla/vue
that referenced
this pull request
Sep 5, 2017
ztlevi
pushed a commit
to ztlevi/vue
that referenced
this pull request
Feb 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
#6193
It seems we still need the value matching check, only detect options change is not enough.