Skip to content

Conversation

alfa-jpn
Copy link

@alfa-jpn alfa-jpn commented Jul 25, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Sorry for create pr before approval...

This PR perfectly fix #4223.

Usage

Vue.config.interpolation = false // default is true.

Best regards,

Hanks10100 and others added 2 commits July 24, 2017 07:32
* build(release weex): ignore the file path of entries

* [release] weex-vue-framework@2.4.2-weex.1
@HerringtonDarkholme
Copy link
Member

Hi @alfa-jpn, thanks for your contribution.

However, there is no silver bullet for server side vue template, especially when users want to mix user generated content with programmer's template. IMHO, Vue's users can and should think over how to separate UGC and template.

On the other hand, Vue's API is already large enough. Vue.config.interpolation can be easily replaced by v-pre that already exists. Users can even provide non-matching regex to mock this pull request.

While we thank your contribution, we might still keep our API surface not too large. (Vue's API is already not as small as it used to be). For more reasoning, please see #6004 (comment).

@yyx990803 yyx990803 closed this Sep 5, 2017
@alfa-jpn
Copy link
Author

alfa-jpn commented Sep 7, 2017

@HerringtonDarkholme
Tanks for reply.

I see.
I also agree with a policy of minimum API.

But, the non-matching regex is weak to version up, because it's implemented by a mocking replace method of string.
(please see #4223 (comment) about v-pre )

So, I created plugin.
https://github.com/alfa-jpn/vue-disable-interpolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable interpolation (mustache-style directives). Vue unusable for apps with user content.
4 participants