fix($compiler): Allow using array value with array v-model in checkboxes, fix #6219 #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmessing
commented
Jul 26, 2017
| @@ -93,7 +93,7 @@ function genCheckboxModel ( | |||
| 'if(Array.isArray($$a)){' + | |||
| `var $$v=${number ? '_n(' + valueBinding + ')' : valueBinding},` + | |||
| '$$i=_i($$a,$$v);' + | |||
| `if($$el.checked){$$i<0&&(${value}=$$a.concat($$v))}` + | |||
| `if($$el.checked){$$i<0&&(${value}=$$a.concat(Array.isArray($$v)?[$$v]:$$v))}` + | |||
There was a problem hiding this comment.
We could just use [$$v] instead of Array.isArray($$v)?[$$v]:$$v I guess but I find this way more verbose (does it make sense?).
There was a problem hiding this comment.
I think using [$$v] is a safer way of doing it. No need for ternary imo
You can add a comment if you want
There was a problem hiding this comment.
@posva, you're right and it's common enough, doesn't need a comment.
FranklinTesla
pushed a commit
to FranklinTesla/vue
that referenced
this pull request
Sep 5, 2017
ztlevi
pushed a commit
to ztlevi/vue
that referenced
this pull request
Feb 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Fix #6219