Allow an object's Symbols to be observed #6704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flow test failure due to facebook/flow#1015 One workaround is
|
Attempting to parseFloat on a Symbol throws the error `Cannot convert a Symbol value to a string`. A Symbol can be cast to a string using `.toString()` or `String()` though, so explicitly casting before parsing resolves the issue, allowing `Vue.set` to be called on Symbols.
dak
force-pushed
the
observe-symbols
branch
from
3ef988a
to
2a35e59
Compare
|
@HerringtonDarkholme I resolved the issue by simply explicitly casting |
HerringtonDarkholme
approved these changes
Sep 28, 2017
ztlevi
pushed a commit
to ztlevi/vue
that referenced
this pull request
Feb 14, 2018
Attempting to parseFloat on a Symbol throws the error `Cannot convert a Symbol value to a string`. A Symbol can be cast to a string using `.toString()` or `String()` though, so explicitly casting before parsing resolves the issue, allowing `Vue.set` to be called on Symbols.
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
Attempting to parseFloat on a Symbol throws the error `Cannot convert a Symbol value to a string`. A Symbol can be cast to a string using `.toString()` or `String()` though, so explicitly casting before parsing resolves the issue, allowing `Vue.set` to be called on Symbols.
WYseven
added a commit
to WYseven/vue
that referenced
this pull request
Jul 5, 2019
This reverts commit 4fd2ce8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to parseFloat on a Symbol throws the error
Cannot convert a Symbol value to a string. Type checking for a Symbol before attempting to parse avoids the error and allowsVue.setto be called on Symbols.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: