New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weex): donot rethrow the captured error on weex platform #7024

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
2 participants
@Hanks10100
Collaborator

Hanks10100 commented Nov 9, 2017

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

Other information:

If the Vue.config.errorHandler is not specified, captured errors will be rethrown on the Weex platform. Add more reliable env check in the logError could fix it.

Besides, I also add an inWeex flag and make the isAndroid and isIOS flag more reliable.

@Hanks10100 Hanks10100 added the weex label Nov 9, 2017

@yyx990803 yyx990803 merged commit c2b1cfe into vuejs:dev Nov 13, 2017

1 check passed

ci/circleci: test-e2e Your tests passed on CircleCI!
Details

@Hanks10100 Hanks10100 deleted the Hanks10100:weex-error-handler branch Nov 14, 2017

lovelope added a commit to lovelope/vue that referenced this pull request Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment