-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): make VNodeDirective properties optional, fix #8013 #8003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Since VNodeDirective has optional properties, we cannot guarantee DirectiveFunction
has non-nullable DirectiveBinding
as argument. So I think changing VNodeDirective
alone is OK.
You're right,
I'm thinking there should still be a separate definition for in vs out though, |
d9e7610
to
8523bb0
Compare
Bump @HerringtonDarkholme edit: ty |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Prevents
Property 'oldValue' is missing in type '{ name: string; value: string; }'.
when using directives in a render function (see test).There should probably actually be three different
VNodeDirective
s:h('', data)
- mostly optional, not readonlyVNodeData
(returned from createElement) - normalised, not readonlyDirectiveFunction
- the current definition (before this change)