New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): support chain call #8595

Merged
merged 15 commits into from Dec 1, 2018

Conversation

Projects
None yet
4 participants
@lzxb
Contributor

lzxb commented Aug 3, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

image

@lzxb lzxb changed the title from Fix types, Support chain call to fix(types) Support chain call Aug 3, 2018

@lzxb lzxb changed the title from fix(types) Support chain call to fix(types): Support chain call Aug 3, 2018

@lzxb lzxb changed the title from fix(types): Support chain call to fix(types): support chain call Aug 3, 2018

lzxb lzxb

@lzxb lzxb closed this Aug 3, 2018

lzxb lzxb

@lzxb lzxb reopened this Aug 3, 2018

@ktsn

Can we add a test case for types?

@ktsn

This comment has been minimized.

Member

ktsn commented Aug 3, 2018

What do you mean? I actually did request you to add some test case in here to confirm that this type annotation is correct.

@lzxb

This comment has been minimized.

Contributor

lzxb commented Aug 3, 2018

Yes, I can add.

@lzxb lzxb force-pushed the lzxb:fix-types branch from 91bc0e1 to c20977a Aug 3, 2018

lzxb added some commits Aug 3, 2018

lzxb lzxb
lzxb lzxb
.use(() => {
})
.mixin({});

This comment has been minimized.

@ktsn

ktsn Aug 4, 2018

Member

This only checks return type of use. We also need to check return type of mixin.

// #8595
it('chain call', () => {
expect(Vue.mixin({}).toBe(Vue))

This comment has been minimized.

@ktsn

ktsn Aug 4, 2018

Member

Looks like a typo.

expect(Vue.mixin({})).toBe(Vue)

lzxb added some commits Aug 4, 2018

@lzxb

This comment has been minimized.

Contributor

lzxb commented Aug 4, 2018

All test add done.

@ktsn

ktsn approved these changes Aug 4, 2018

@chillcaw

Changes and the added test look solid

@yyx990803 yyx990803 merged commit c711ec1 into vuejs:dev Dec 1, 2018

5 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment