Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly disable a transition by setting it to false (fix #9320) #9366

Closed
wants to merge 2 commits into from

Conversation

Itisfilipe
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
With this change will be possible to set appear to false and disable it dynamically. fix #9320

Appear set to false

image

Appear defined but not set

image

Appear not defined

Notice that consider appear to be False when absent would require either a change for the corner case or a breaking change
image

The @appear hook is being invoked when appear is not specified or is falsy. This change make it
possible to dynamically disable it by setting :appear="false" when needed.
@posva

This comment has been minimized.

@Itisfilipe
Copy link
Author

@posva no worries, feel free to completely disregard this PR. I have one question though, test-cover is working local but failing on circleci, is that something I should expect to happen in this codebase?

@posva
Copy link
Member

posva commented Jan 25, 2019

Not really, the test failing is called should handle random shuffle. I haven't check the test but it could be indeed failing because of a random thing

@Itisfilipe

This comment has been minimized.

@posva

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition's @appear hook invoked even when appear not specified / falsy
3 participants