Skip to content

feat(global-api): warn when plugin is invalid #9601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat(global-api): warn when plugin is invalid #9601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b420f2b
feat(global-api): warn when plugin is invalid
dsseng Mar 1, 2019
aa1d9ac
test(global-api): remove failing test
dsseng Mar 1, 2019
900a7bb
Update use.spec.js
dsseng Mar 5, 2019
c826d08
test: fix string, adding missing 'or '
LinusBorg Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/core/global-api/use.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* @flow */

import { toArray } from '../util/index'
import { toArray, warn } from '../util/index'

export function initUse (Vue: GlobalAPI) {
Vue.use = function (plugin: Function | Object) {
Expand All @@ -12,10 +12,14 @@ export function initUse (Vue: GlobalAPI) {
// additional parameters
const args = toArray(arguments, 1)
args.unshift(this)
if (typeof plugin.install === 'function') {
if (plugin && typeof plugin.install === 'function') {
plugin.install.apply(plugin, args)
} else if (typeof plugin === 'function') {
plugin.apply(null, args)
} else if (process.env.NODE_ENV !== 'production') {
warn(
'Plugin should be either function or object with install method.'
)
}
installedPlugins.push(plugin)
return this
Expand Down
14 changes: 14 additions & 0 deletions test/unit/features/global-api/use.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,18 @@ describe('Global API: use', () => {
it('chain call', () => {
expect(Vue.use(() => {})).toBe(Vue)
})

it('should warn if using invalid plugin', () => {
const Ctor1 = Vue.extend({})
Ctor1.use('hello')
expect('Plugin should be either function or object with install method.').toHaveBeenWarned()

const Ctor2 = Vue.extend({})
Ctor2.use(undefined)
expect('Plugin should be either function or object with install method.').toHaveBeenWarned()

const Ctor3 = Vue.extend({})
Ctor3.use(null)
expect('Plugin should be either function or object with install method.').toHaveBeenWarned()
})
})