Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transition): looking up `context` of transition #9668

Merged
merged 5 commits into from Mar 14, 2019

Conversation

Projects
2 participants
@Shasharoman
Copy link
Contributor

Shasharoman commented Mar 10, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
fixed #9628
Transition inside child component with v-if should be no enter-transition, it depend on appear attribute.

@Shasharoman

This comment has been minimized.

Copy link
Contributor Author

Shasharoman commented Mar 11, 2019

This pull request is also fixed #9364.

@Shasharoman

This comment has been minimized.

Copy link
Contributor Author

Shasharoman commented Mar 12, 2019

The test-e2e failed, I thought it was a problem with CircleCI, so I ignored it. Today I found that the test case was not updated. But also found some other hidden dangers, this PR does not seem to be compatible with the previous version, suppose there is a component of my-transition, his template is <transition><div>xxx</div></transition>, if used like this:

<my-transition v-if="showing"></my-transition>

When showing is changed from false to true, the previous version will have a transition effect, but the new PR will result in having to specify an appear attribute for the transition to have a transition effect.

@yyx990803 yyx990803 added this to To do in Maintenance Mar 13, 2019

@Shasharoman Shasharoman changed the title Transition fix fix(transition): looking up `context` of transition Mar 13, 2019

@yyx990803 yyx990803 merged commit 4de4649 into vuejs:dev Mar 14, 2019

5 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details

Maintenance automation moved this from To do to Done Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.