Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9727 #9728

Merged
merged 2 commits into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@VitorLuizC
Copy link
Contributor

commented Mar 17, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR fix #9727.

@posva

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Can you add a test using the createElement function (not explicitly setting the type VNodeData)

@VitorLuizC

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

Done. Now, theres a component on vue-test.ts with render function that create elements with VNodeData's style as string | object and object[].

@posva

posva approved these changes Mar 17, 2019

@yyx990803 yyx990803 merged commit 982d5a4 into vuejs:dev Mar 18, 2019

5 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.