Skip to content

Conversation

backbone87
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
If people used the wrongly typed part of the changed interface, typescript compiler may complain now. No effect in transpileOnly mode, it only effects the TS typechecker.

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

the component property of the return value of the
AsyncComponentFactory should be a promise and not a
function returning a promise

…ty of the return value of theAsyncComponentFactory should be a promise and not afunction returning a promise
@backbone87 backbone87 force-pushed the fix-async-component-typings branch from e2d60f1 to 2afe691 Compare March 28, 2019 22:09
@backbone87
Copy link
Author

ci errors seem unrelated

@backbone87
Copy link
Author

backbone87 commented Jul 14, 2019

@LinusBorg sorry for pinging you directly, but since there is no response on this, i just wanted to raise someones attension: can this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant