Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): production preload files #9802

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Apr 1, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

In webpack production mode, some modules may be concatenated by scope hoisting via ModuleConcatenationPlugin, so these modules' mapping information will be lost.

For example: modules info for qux.js, quux.js and quuz.js are lost

{
  "modules": [
    {
      "chunks": [...],
      "identifier": "foo.js",
    },
    {
      "chunks": [...],
      "identifier": "bar.js"
    },
    {
      "chunks": [...],
      "identifier": "baz.js",
      "modules": [
        {
          "identifier": "qux.js"
        },
        {
          "identifier": "quux.js"
        }
        {
          "identifier": "quuz.js"
        }
      ]
    }
  ]
}

This pr change is traversing the ConcatenatedModule and populate the modules info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants