Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix running e2e test on windows #9909

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented Apr 23, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: fix running e2e test on Windows

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Can not find phantomjs binary when run e2e test on Windows. same as PR

@zrh122 zrh122 changed the title fix running e2e test on windows test: fix running e2e test on windows Apr 23, 2019
@yyx990803 yyx990803 merged commit bd6cea0 into vuejs:dev Apr 25, 2019
@vue-bot
Copy link
Contributor

vue-bot commented Apr 25, 2019

Hey @zrh122, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@zrh122 zrh122 deleted the e2e-config branch April 26, 2019 01:21
kiku-jw pushed a commit to kiku-jw/vue that referenced this pull request Jun 18, 2019
dukegod added a commit to dukegod/vue that referenced this pull request Jun 21, 2019
* commit 'bad3c326a3f8b8e0d3bcf07917dc0adf97c32351': (911 commits)
  chore: update sponsors [ci skip] (vuejs#10158)
  chore: fix sponsor url [ci skip]
  chore: update sponsors [ci skip] (vuejs#10136)
  chore: update sponsors [ci skip] (vuejs#10130)
  chore: update sponsors [ci skip] (vuejs#10113)
  chore(typo): fix comment typo (vuejs#10101)
  chore: update sponsors [ci skip] (vuejs#10064)
  Create FUNDING.yml
  chore: update sponsors [ci skip] (vuejs#10031)
  chore(typo): fix README tag mismatch (vuejs#9934)
  chore(typo): fix typo in comments (vuejs#9995)
  chore: update sponsors [ci skip] (vuejs#9970)
  chore: update sponsors [ci skip] (vuejs#9933)
  fix: fix function expression regex (vuejs#9922)
  fix(types): fix global namespace declaration for UMD bundle (vuejs#9912)
  fix(compiler): Remove the warning for valid v-slot value (vuejs#9917)
  polish: add warning when .native modifier is used on native HTML elements (vuejs#9884)
  test: fix running e2e test on windows (vuejs#9909)
  refactor: remove useless parameter to the function removeVnodes (vuejs#9914)
  test: separate failing test for TS 3.4
  ...

# Conflicts:
#	packages/weex-template-compiler/build.js
#	packages/weex-vue-framework/factory.js
#	packages/weex-vue-framework/index.js
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants