Skip to content

Conversation

damianstasik
Copy link

@damianstasik damianstasik commented Apr 28, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The parseTemplate method has the optional contentPlaceholder parameter which allows changing the default placeholder to a custom one. The problem is that this parameter is not used once, so we could either remove it or allow users to change it. I am not a fan of hardcoded values and decided to create this tiny PR which introduces a new Renderer option that is passed to the parseTemplate.

@damianstasik damianstasik force-pushed the feat/ssr-content-placeholder branch from 91bf815 to 359a7c2 Compare April 28, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants