Skip to content

fix(keep-alive): cache what is really needed not the whole VNode… - #9962

Closed
zrh122 wants to merge 1 commit into
vuejs:devfrom
zrh122:refactor-keepalive
Closed

fix(keep-alive): cache what is really needed not the whole VNode…#9962
zrh122 wants to merge 1 commit into
vuejs:devfrom
zrh122:refactor-keepalive

Conversation

@zrh122

@zrh122 zrh122 commented May 1, 2019

Copy link
Copy Markdown
Contributor

cache what is really needed not the whole VNode data. it also fixes #9842
Fixes #2549
Fixes #9972

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@kadet1090

Copy link
Copy Markdown

Any update on when we can expect this PR to be merged?

@pcm0nk

pcm0nk commented May 28, 2020

Copy link
Copy Markdown

Can we have an update when this going to be merged? shouldnt this be high priority as it makes the app not usable after some time working and navigating. Also keep-alive has impact on page load. If this gets merged or at least a workaround is provided ( not removing keep-alive) would be nice.

@dyu

dyu commented Jun 1, 2020

Copy link
Copy Markdown

I just noticed this bug too. The kept-alive node is not being destroyed. This is such a critical bug for a core component that's used by many

lming referenced this pull request in shinyinc/vue Jun 1, 2020
@chencmgithub

Copy link
Copy Markdown

Any update on when we can expect this PR to be merged?

which version had fixed the bug ??

@RichieChoo

Copy link
Copy Markdown

Any news?

@posva posva changed the title refactor(keep-alive): cache what is really needed not the whole VNode… fix(keep-alive): cache what is really needed not the whole VNode… Feb 24, 2021
@posva

posva commented Apr 16, 2021

Copy link
Copy Markdown
Member

@zrh122 Thanks a lot for this! I reopened a new one with a refactor to avoid creating a new function on every render: #12015

@posva posva closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

7 participants