Skip to content

module foo's incorrect registration on server-side #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

module foo's incorrect registration on server-side #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docs/guide/data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,8 @@ export default {

// Server-side only
serverPrefetch () {
// register store module on server-side and dont preserve state at current step,
// since module foo's state has not been initiated yet.
this.registerFoo()
return this.fooInc()
},
Expand All @@ -251,7 +253,7 @@ export default {
const alreadyIncremented = !!this.$store.state.foo

// We register the foo module
this.registerFoo()
this.registerFoo(true)

if (!alreadyIncremented) {
this.fooInc()
Expand All @@ -265,9 +267,9 @@ export default {
},

methods: {
registerFoo () {
registerFoo (shoudPreserve = false) {
// Preserve the previous state if it was injected from the server
this.$store.registerModule('foo', fooStoreModule, { preserveState: true })
this.$store.registerModule('foo', fooStoreModule, { preserveState: shoudPreserve })
},

fooInc () {
Expand Down