Skip to content

fix: the context in cancelCallback as vm #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: the context in cancelCallback as vm #126

wants to merge 1 commit into from

Conversation

jkiimm
Copy link

@jkiimm jkiimm commented Sep 22, 2017

Closes #120

posva
posva requested changes Sep 22, 2017
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the bind of the cancel callback inside of the bind function instead? Also, can you remove the files Form. The distance folder?

@jkiimm
Copy link
Author

jkiimm commented Sep 25, 2017

Can you do the bind of the cancel callback inside of the bind function instead?

Sorry for my English. I don't understand clearly. Is not it already?

can you remove the files Form. The distance folder?

It means that the files in the dist folder should be removed from the PR?

@posva posva closed this in c122200 Sep 26, 2017
@posva
Copy link
Member

posva commented Sep 26, 2017

No worries, I just added the check and will release a new version very soon

posva added a commit that referenced this pull request Jul 10, 2018
@posva
chore(package): update rollup-plugin-buble to version 0.18.0 (#129)
36ec337 
Closes #126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkiimm @posva