Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import nuxt composables from #imports #1457

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

danielroe
Copy link
Member

This is a DX improvement when developing - we can avoid loading the entire barrel file at #app by using the new granular imports merged in nuxt/nuxt#23951.

@codecov-commenter
Copy link

Codecov Report

Merging #1457 (4be5013) into main (343207c) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #1457   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          21       21           
  Lines        3289     3289           
  Branches      286      286           
=======================================
  Hits         2700     2700           
  Misses        589      589           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I wasn't aware

@posva posva merged commit 7e1a273 into vuejs:main Nov 8, 2023
5 checks passed
@danielroe danielroe deleted the app-import branch November 8, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants