Skip to content

Commit

Permalink
fix: textlint bug causing PR's to fail checks fix #2636 (#2637)
Browse files Browse the repository at this point in the history
  • Loading branch information
d-pollard authored Oct 1, 2020
1 parent 2fbad28 commit 64e92ca
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/docs/docs/miscellaneous/design-concepts.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ VuePress 1.0 has been rewritten extensively, and the most important one is the i

### Decoupling

With plugins, we can implement many of the core functions with plugins, and you can see many built-in plugins [here](https://github.com/vuejs/vuepress/tree/master/packages/%40vuepress/core/lib/node/internal-plugins) that cover many of the core functions of VuePress, which used to blend in all parts of the code base, but now they’re clear at a glance.
With plugins, we can implement many of the core functions with plugins, and you can see many built-in plugins [here](https://github.com/vuejs/vuepress/tree/master/packages/%40vuepress/core/lib/node/internal-plugins) that cover many of the core functions of VuePress, which used to blend in all parts of the codebase, but now they’re clear at a glance.

### Configuration management

In the past, when we came across some less common requirements, we had some doubts: if we wanted to not support it, VuePress usage scenarios were limited; but if we wanted to support it, we had to write it into the core code base and set up a separate configuration API for it. For the maintainers, apart from not conducive to long-term maintenance, this sometimes makes us feel exhausted. We must think of some better solutions. Yes, this is plugin.
In the past, when we came across some less common requirements, we had some doubts: if we wanted to not support it, VuePress usage scenarios were limited; but if we wanted to support it, we had to write it into the core codebase and set up a separate configuration API for it. For the maintainers, apart from not conducive to long-term maintenance, this sometimes makes us feel exhausted. We must think of some better solutions. Yes, this is plugin.

### `.vuepress/config.js` is also a plugin

Expand Down
2 changes: 1 addition & 1 deletion packages/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"textlint-rule-diacritics": "^1.0.0",
"textlint-rule-en-capitalization": "^2.0.2",
"textlint-rule-stop-words": "^1.0.17",
"textlint-rule-terminology": "^1.1.30",
"textlint-rule-terminology": "^2.1.4",
"textlint-rule-write-good": "^1.6.2",
"vue-toasted": "^1.1.25",
"vuepress": "1.6.0",
Expand Down

0 comments on commit 64e92ca

Please sign in to comment.