Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($config): Allow overriding badges colors (close #1940) #1941

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

kefranabg
Copy link
Collaborator

Summary

Fix #1940

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@@ -4,6 +4,9 @@ $textColor = #2c3e50
$borderColor = #eaecef
$codeBgColor = #282c34
$arrowBgColor = #ccc
$badgeTip = #42b983
$badgeWarning = darken(#ffe564, 35%)
$badgeError = #DA5961
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with $accentColor, $textColor, etc. , adding "color" to variable name could be better.

For example: $badgeTipColor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, how to add version badge in docs for this kind of feature? 🤔

@kefranabg
Copy link
Collaborator Author

kefranabg commented Oct 23, 2019

@meteorlxy yes... Using badges for versioning looks kind of limited sometimes 😅

@kefranabg kefranabg merged commit 89a4a8d into master Oct 26, 2019
@kefranabg kefranabg deleted the feat/badge-color-override branch October 26, 2019 14:39
@vue-bot
Copy link

vue-bot commented Oct 26, 2019

Hey @kefranabg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow badge color override from palette.styl
4 participants