Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link nav-item underline to $accentColor #230

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Link nav-item underline to $accentColor #230

merged 1 commit into from
Apr 23, 2018

Conversation

frankdugan3
Copy link
Contributor

It would appear the underline style of nav-item should be related to $accentColor to avoid color palette clashes if the user supplies override.styl.

ycmjason
ycmjason approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@ycmjason ycmjason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get this published ASAP! 😿

@yyx990803 yyx990803 merged commit ddb590d into vuejs:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycmjason ycmjason ycmjason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankdugan3 @ycmjason @yyx990803