fix(dev build): reserving unused port #26 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egoist
reviewed
Apr 14, 2018
ulivz
requested changes
Apr 15, 2018
lib/dev.js
Outdated
| portfinder.basePort = cliOptions.port || options.siteConfig.port || 8080 | ||
| const port = await portfinder.getPortPromise() | ||
| .then((port) => { | ||
| return port |
There was a problem hiding this comment.
.then here can be removed if you only want to get the available port.
There was a problem hiding this comment.
@ulivz Thanks!!
completely missed it , will fix it now.
yyx990803
requested changes
Apr 15, 2018
lib/dev.js
Outdated
| const port = cliOptions.port || options.siteConfig.port || 8080 | ||
| portfinder.basePort = cliOptions.port || options.siteConfig.port || 8080 | ||
| const port = await portfinder.getPortPromise() | ||
| .catch(err => console.log(err)) |
There was a problem hiding this comment.
no need to catch here, this should propagate up the call stack and be logged anyway.
Closed
…000 as port 8080 was used by webpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.