Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive url matching doesn't work as expected #897

Closed
alexjoverm opened this issue Oct 2, 2018 · 1 comment
Closed

Case sensitive url matching doesn't work as expected #897

alexjoverm opened this issue Oct 2, 2018 · 1 comment

Comments

@alexjoverm
Copy link
Contributor

Bug report

Some browsers/hostings change the urls to lowercase. Because of that, the findPageForPath function on ClientComputedMixin.js file doesn't find the correct path and shows the NotFound component.

An easy fix for this could be to change the line check to:

if (page.path.toLowerCase() === path.toLowerCase()) {

Or otherwise to provide a way where it can be configured from outside.

Version

1.0.0-alpha.2

Steps to reproduce

What is expected?

The right component should be found, making the page render correctly

What is actually happening?

The NotFound component is rendered

Other relevant information

  • Your OS: Mac OS
  • Node.js version: 8.9.3
  • Browser version: Several
  • Is this a global or local install? Local
  • Which package manager did you use for the install? npm
alexjoverm added a commit to alexjoverm/vuepress that referenced this issue Oct 2, 2018
@alexjoverm
Copy link
Contributor Author

Opened #897 as a fix proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant