Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix($core): load theme bug and typo #1247

Merged
merged 4 commits into from
Jan 29, 2019
Merged

fix($core): load theme bug and typo #1247

merged 4 commits into from
Jan 29, 2019

Conversation

meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Jan 29, 2019 •
edited
Loading

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

  • fix typo layourDir to layoutDir
  • fix bug that never throw error when Layout.vue does not exist
  • fix typo that the filename of default NotFound.vue is Layout.vue

ulivz
ulivz approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulivz ulivz merged commit 49c5983 into vuejs:master Jan 29, 2019
@meteorlxy meteorlxy deleted the fix/load-theme branch January 29, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulivz ulivz ulivz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorlxy @ulivz