-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(options): make enhancers async ready without breaking changes #1546
Conversation
Hello ! @Slashgear is it needed again ? You want to add the possibility to make async request on that that's the need behind ? |
Yep, that was the need hidden behind. It was needed for one of my project, but without answer I had to switch from static site generator. |
sorry to hear that. as we create the core team we need a bit time to establish the needs and work on it. |
Thank's for your work @Slashgear i have to look a bit about async stuff and test here but it look great ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Slashgear Thank you for this PR
I just made a test and everything seems to work as expected 👍
Sorry for the delay 😉
I just think we should update the documentation to let users know that extendPageData
is also working as an async function. I can take care of this update if you want, just let me know !
@kefranabg I don't have the time now to do it :-) So, go for it 😄 |
1e01200
to
3cbfbf1
Compare
Hey @Slashgear, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
There is no dedicated documentation for async options for now
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
I am working on a project where I use vuepress alpha.47. I am trying to fetch dynamically information for
$page
data base on afrontmatter
value.Here is the code of the plugin I am trying to introduce in my project.
But extendPageData is not async ready for now.
So this is my contribution to make is async ready 🎉
Tested locally with
yarn link