docs: update contributing guide #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodesOfRa
reviewed
Jul 3, 2020
|
|
||
| Good from here you have everything ready. You need to link VuePress to your project. | ||
| # Initalize a new npm project | ||
| npm init |
There was a problem hiding this comment.
it would be nice to mention yarn init as an alternative too :)
There was a problem hiding this comment.
Good suggestion! Just added it
bencodezen
commented
Jul 3, 2020
bencodezen
commented
Jul 3, 2020
CodesOfRa
approved these changes
Jul 3, 2020
…press into docs/update-contribution-guide
There was a problem hiding this comment.
@bencodezen Please check out CONTRIBUTING.md. I believe they should be sync(or only keep one of them).
kefranabg
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Nice! agreed with @billyyyyy3320, we should update the CONTRIBUTING.md as well
ulivz
approved these changes
Jul 19, 2020
|
Yes, we should update the |
larionov
pushed a commit
to larionov/vuepress
that referenced
this pull request
Aug 19, 2020
* docs: update contributing guide * docs: add yarn init option * fix: markdown linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: