Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: algolia custom theme (close: #331) #334

Closed
wants to merge 1 commit into from
Closed

fix: algolia custom theme (close: #331) #334

wants to merge 1 commit into from

Conversation

nerdoza
Copy link

@nerdoza nerdoza commented May 2, 2018

No description provided.

@ulivz
Copy link
Member

ulivz commented May 10, 2018

This change doesn't make sense. relative path means the consumer component will rely on the relative position to the AlgoliaSearchBox component.

As doc said:

once you eject, you are on your own and won't be receiving future updates or bug fixes to the default theme even if you upgrade VuePress.

So for now, you should change the reference path at your ejected files directly:

From:

import AlgoliaSearchBox from '@AlgoliaSearchBox'

To:

import AlgoliaSearchBox from '[Your path]'

@ulivz ulivz closed this May 10, 2018
@nerdoza
Copy link
Author

nerdoza commented May 10, 2018

@ulivz, I don't see the difference here considering that every other component in the theme uses relative paths for every other component. It appears that the alias was used primarily as a method to be able to make it a noOp component based on the config settings and the absolute path seems like an oversight more than an intentional decision given that this is the only component that is currently using an absolute path.

For those that will ultimately stumble across this in search of resolution:
If you ejected the theme and are attempting to style the Algolia Search Box component and are noticing that it is not responding to your config.styl overrides or that the changes you are making to the component are not being reflected it's because it's still pointing to the default theme's component and config.styl values. The above the change is required to make it use the ejected component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants