Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about conflicts between state and module #1365

Merged
merged 2 commits into from
Nov 10, 2019

Conversation

simplesmiler
Copy link
Member

Fixes #1363.

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/store.js Outdated
if (process.env.NODE_ENV !== 'production') {
if (moduleName in parentState) {
console.warn(
`[vuex] state field "${moduleName}" was overridden by a module with the same name`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simplesmiler what do u think about including the module name in the latter part as well? [vuex] state field "${moduleName}" was overridden by a module with the same name ("${moduleName}")

@winniehell
Copy link

@simplesmiler do you intend to address the review comment above / complete this pull request?

@winniehell
Copy link

@ktsn Given that you already approved, do you think this can be merged as is it? Or would you prefer applying the review comment above?

@winniehell
Copy link

@yyx990803 could you please take a look if this can be merged?

@winniehell
Copy link

@ktsn @yyx990803 Could you please merge this or comment what's missing? It has been approved over a year ago. 😟

@ktsn ktsn merged commit 538ee58 into vuejs:dev Nov 10, 2019
@lavyun
Copy link

lavyun commented Nov 15, 2019

How can I close this warn, suddenly printed a lot of such warnings in my project., Although it doesn't matter, but the sudden warning was terrible for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display warning if root state property has the same name with module
5 participants