update ja docs #1400
Merged
update ja docs #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
reviewed
Sep 17, 2018
docs/ja/guide/testing.md
Outdated
| @@ -127,19 +127,19 @@ describe('actions', () => { | |||
| }) | |||
| ``` | |||
|
|
|||
| If you have spies available in your testing environment (for example via [Sinon.JS](http://sinonjs.org/)), you can use them instead of the `testAction` helper: | |||
| テスト環境(例えば[Sinon.JS](http://sinonjs.org/)で)において利用可能なスパイがあるのなら、`testAction` ヘルパーの代わりにそれらを使用できます: | |||
There was a problem hiding this comment.
SinonJS についてはスパイの方に掛かっているので、テスト環境において利用可能なスパイがあるのなら(例えばSinon.JS) にするのはどうでしょうか？
docs/ja/api/README.md
Outdated
|
|
||
| 監視を止める場合は、ハンドラ関数の返り値を関数として呼び出します。 | ||
| 監視を止める場合は、unwatch 関数の返り値を関数として呼び出します。 |
There was a problem hiding this comment.
返された unwatch 関数を呼び出します が意図としては正しいですね。
docs/ja/installation.md
Outdated
| npm install es6-promise --save # NPM | ||
| yarn add es6-promise # Yarn | ||
| ``` | ||
|
|
||
| Furthermore, add the below line into anywhere in your code before using Vuex: | ||
| さらに、Vuex を使用する前に、コードのどこかに次のを行を追加します: |
docs/ja/api/README.md
Outdated
| @@ -224,7 +224,7 @@ const store = new Vuex.Store({ ...options }) | |||
|
|
|||
| 第1引数は、オプションで名前空間文字列にすることができます。[詳細](../guide/modules.md#binding-helpers-with-namespace) | |||
|
|
|||
| The Second object argument's members can be a function. `function(state: any)` | |||
| 第2引数のオブジェクト引数メンバーには関数 `function(state: any)` を指定できます。 | |||
There was a problem hiding this comment.
オブジェクト引数メンバー
これは少し何を指しているのか分かりづらいので、助詞を入れるなどして 第2引数のオブジェクトのメンバーには とするのはどうでしょうか？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/ping @ktsn